[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: rfc: C99 style of the uintN_t types
On Tue, Aug 12, 2008 at 9:15 PM, Thor Lancelot Simon
> Please do not do this. A similar script was once used to "remove trailing
> whitespace" from the source tree -- which it gladly did, including in binary
> firmware images and other inappropriate files.
There was example of comiter's inaccuracy. Before any commit is done
the cvs diff should be executed and reviewed. (1)
> Also, this kind of bulk change will cause huge numbers of spurious conflicts
> when 3rd-party components are (as they periodically are) reimported. That
> causes a lot of work for other developers.
The same - look to (1).
> The code using u_intX_t was
> conformant to the style in effect when it was written, and if it is changed
> at all, it should be changed gradually as other changes are made (and tested)
> in each file where it appears.
Why do not start to fix file by file? I.e. you need to patch something
in the xxx.c. Put the proper type changes and after this apply your
With Best Regards,
Main Index |
Thread Index |