tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: rfc: C99 style of the uintN_t types

On Tue, Aug 12, 2008 at 01:26:11PM +0300, Andy Shevchenko wrote:
> Proposal is to fix current code base to recommended style accordingly.
> The simple script can do it, f.e. for sys/arch:
>   find sys/arch -type f | grep -vw CVS | xargs perl -pi -e
> 's,u_(int\d+_t),u$1,g'

Please do not do this.  A similar script was once used to "remove trailing
whitespace" from the source tree -- which it gladly did, including in binary
firmware images and other inappropriate files.

Also, this kind of bulk change will cause huge numbers of spurious conflicts
when 3rd-party components are (as they periodically are) reimported.  That
causes a lot of work for other developers.  The code using u_intX_t was
conformant to the style in effect when it was written, and if it is changed
at all, it should be changed gradually as other changes are made (and tested)
in each file where it appears.


Home | Main Index | Thread Index | Old Index