tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Bug fix for PR 26470 for review



On Sat, May 24, 2008 at 03:10:38PM -0700, Dennis Ferguson wrote:
> I'd note, however, that in all normal cases the code which
> is there now will only be doing a single add, and that your patch changes
> this into a couple of divides in all cases.  It might be better to save
> the divides just for the case where the single add fails to advance the 
> time past `now' as this should seldom happen.

settimeofday and other time skipping things are not normal events.
They generally happen once after boot. There's a reason why this is not
exposed far more often :-) Just using the div/mod arithmetic is much
simpler and this is not a critical code path

Joerg


Home | Main Index | Thread Index | Old Index