Re: select/poll optimization

[Andrew Doran <ad%netbsd.org@localhost>]

On Sat, Mar 22, 2008 at 08:03:27AM +0100, Christoph Egger wrote:

> >http://www.netbsd.org/~ad/percpu-select-56.diff
> 
> There is a missing mutex_spin_exit() in this
> file
...
> +             sleepq_enqueue(&sc->sc_sleepq, sc, "select", &select_sobj);
> 
>       --->    mutex_spin_exit(&sc->sc_lock);   <---
> 
> +             KERNEL_UNLOCK_ALL(NULL, &l->l_biglocks);        /* XXX */
> +             error = sleepq_block(timo, true);
>               if (error != 0)
>                       break;

sleepq_block() drops the sleep queue interlock, so it's not a problem.

Thanks,
Andrew