tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Replace lockmgr for vnodes

On Tue Jan 29 2008 at 03:48:57 +0000, David Holland wrote:
> On Mon, Jan 28, 2008 at 06:14:27PM -0800, Bill Stouder-Studenmund wrote:
>  > Do all of the places that try to lock a kmutex always check return values? 
>  > The older locking primitives, such as vnode locks, often were called in
>  > places that didn't cope with getting a return error code. Many times that
>  > means they didn't bother to check. :-)
> No, they don't. In the long run I'm intending to fix at least the
> vnode locks, because IMO they should be interruptible, but that'll
> likely be a slow process.

While this is theoretically a good idea, I am not sure it won't introduce
more bugs than it works around.  Every lock call would demand an error
path, and error paths are usually good at one thing: not being tested
at all.  Increased code clutter is another downside.

Antti Kantee <>                     Of course he runs 
    "la qualité la plus indispensable du cuisinier est l'exactitude"

Home | Main Index | Thread Index | Old Index