tech-crypto archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: NetBSD 4.0 sshd: protocol violation

> Index: src/crypto/dist/ssh/session.c
> -             packet_put_char(WCOREDUMP(status));
> +             packet_put_char(WCOREDUMP(status) ? 1 : 0);

On reflection, I realize this is a bug that needs fixing anyway,
regardless of whether it fixes my issue; there's nothing in
WCOREDUMP()'s interface that promises the low 8 bits of its return
value are nonzero when it returns true, meaning it could falsely
indicate no coredump if the system's WCOREDUMP() happens to return,
say, 0-or-0x8000 instead of the 0-or-0x80 we use.

Who should feed these things back to openssh?  Me?  Our ssh importer?
Someone else?

/~\ The ASCII                           der Mouse
\ / Ribbon Campaign
 X  Against HTML     
/ \ Email!           7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B

Home | Main Index | Thread Index | Old Index