Re: NetBSD 4.0 sshd: protocol violation

[Alan Barrett <apb%cequrux.com@localhost>]

On Tue, 19 Feb 2008, der Mouse wrote:
> the core-dumped boolean was 0x80 (probably because that's the
> core-dumped bit in a wait() status), and of booleans RFC4251 says
> "applications MUST NOT store values other than 0 and 1".

Does this patch fix it?  If so, the change should be fed back to openssh.

Index: src/crypto/dist/ssh/session.c
--- session.c   10 Mar 2007 22:52:09 -0000      1.44
+++ session.c   19 Feb 2008 18:00:37 -0000
@@ -1998,7 +1998,7 @@
        } else if (WIFSIGNALED(status)) {
                channel_request_start(s->chanid, "exit-signal", 0);
                packet_put_cstring(sig2name(WTERMSIG(status)));
-               packet_put_char(WCOREDUMP(status));
+               packet_put_char(WCOREDUMP(status) ? 1 : 0);
                packet_put_cstring("");
                packet_put_cstring("");
                packet_send();