CVS commit: [netbsd-11] src/sys/kern

["Martin Husemann" <martin%netbsd.org@localhost>]

Module Name:    src
Committed By:   martin
Date:           Sun Oct 25 11:29:24 UTC 2026

Modified Files:
        src/sys/kern [netbsd-11]: kern_proc.c subr_pool.c vfs_vnode.c

Log Message:
Pull up following revision(s) (requested by riastradh in ticket #555):

        sys/kern/vfs_vnode.c: revision 1.160
        sys/kern/kern_proc.c: revision 1.287
        sys/kern/subr_pool.c: revision 1.296
        sys/kern/subr_pool.c: revision 1.297
        sys/kern/subr_pool.c: revision 1.299

subr_pool.c: Sort includes.

No functional change intended.  Preparation for:
PR kern/58378: Kernel error code origination lacks dtrace probes

subr_pool.c: Sprinkle SET_ERROR dtrace probes.

PR kern/58378: Kernel error code origination lacks dtrace probes

vnode(9): Allocate vnodes with declared alignment.

The definition of struct vnode_impl includes various
__aligned(COHERENCY_UNIT), so the compiler will assume struct vnode
pointers are aligned as such.

As a space optimization on uniprocessor systems, we define the
variable `coherency_unit' (as part of the module ABI) to be
COHERENCY_UNIT (often 64 or 128) in MULTIPROCESSOR builds, but
toALIGNBYTES+1 (often 4, 8, or 16) for !MULTIPROCESSOR builds where
cache line sharing isn't as much of a problem.

But this isn't safe as an optimization for allocating objects that
have statically declared (as part of their ABI) COHERENCY_UNIT
alignment.

PR port-evbmips/60812: UBSan: Undefined Behavior in [sys-src]  member
access within misaligned address  [..] for type '[..]' which requires
128 byte alignment

proc(9): Allocate struct proc with declared alignment.

The definition of struct proc includes __aligned(COHERENCY_UNIT) on
the p_auxlock member, so the compiler will assume struct proc
pointers are aligned as such.

As a space optimization on uniprocessor systems, we define the
variable `coherency_unit' (as part of the module ABI) to be
COHERENCY_UNIT (often 64 or 128) in MULTIPROCESSOR builds, but
toALIGNBYTES+1 (often 4, 8, or 16) for !MULTIPROCESSOR builds where
cache line sharing isn't as much of a problem.

But this isn't safe as an optimization for allocating objects that
have statically declared (as part of their ABI) COHERENCY_UNIT
alignment.

PR port-evbmips/60812: UBSan: Undefined Behavior in [sys-src]  member
access within misaligned address  [..] for type '[..]' which requires
128 byte alignment

pool_cache(9): Allocate struct pool_cache with declared alignment.

The definition of struct pool_cache has __aligned(CACHE_LINE_SIZE) on
the pc_fullgroups member, so the compiler will assume struct
pool_cache pointers are aligned as such.

As a space optimization on uniprocessor systems, we define the
variable `coherency_unit' (as part of the module ABI) to be
COHERENCY_UNIT (often 64 or 128) in MULTIPROCESSOR builds, but
to ALIGNBYTES+1 (often 4, 8, or 16) for !MULTIPROCESSOR builds where
cache line sharing isn't as much of a problem.

But this isn't safe as an optimization for allocating objects that
have statically declared (as part of their ABI) CACHE_LINE_SIZE
alignment.

PR port-evbmips/60812: UBSan: Undefined Behavior in [sys-src]  member
access within misaligned address  [..] for type '[..]' which requires
128 byte alignment


To generate a diff of this commit:
cvs rdiff -u -r1.280.2.2 -r1.280.2.3 src/sys/kern/kern_proc.c
cvs rdiff -u -r1.295 -r1.295.2.1 src/sys/kern/subr_pool.c
cvs rdiff -u -r1.156.2.1 -r1.156.2.2 src/sys/kern/vfs_vnode.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.