CVS commit: src/sys/dev/raidframe

["Thor Lancelot Simon" <tls%netbsd.org@localhost>]

Module Name:    src
Committed By:   tls
Date:           Wed Oct 21 01:19:18 UTC 2026

Modified Files:
        src/sys/dev/raidframe: rf_disks.c rf_netbsdkintf.c rf_reconstruct.c

Log Message:
Fix several RAIDframe bugs relating to spare disks (most minor, one or two not)

1) Incomplete component swap - this can leave the replacement's auto_configured,
   partitionSize, etc. set to the old component's values or in some cases
   to zero (component missing at boot etc).

2) A write error on the spare during reconstruction should fail the spare.
   Otherwise, multi-spare arrays will never proceed from a bad spare to a
   good one.

3) rf_remove_hot_spare and rf_delete_component fail to close the vnode
   in the autoconfigured case.  rf_remove_hot_spare also appears to have
   an off-by-one error.

4) When we bring a spare into operation and update its label, we fail to
   call rf_component_label_set_partitionsize().  It could get stuck at 0
   or whatever was in there before, since at present spares don't get labels
   written in most cases until they are used.

5) Missing locking around access to the recon_in_progress variable.  It is
   likely possible for silly use of raidctl to cause...problems.


To generate a diff of this commit:
cvs rdiff -u -r1.97 -r1.98 src/sys/dev/raidframe/rf_disks.c
cvs rdiff -u -r1.420 -r1.421 src/sys/dev/raidframe/rf_netbsdkintf.c
cvs rdiff -u -r1.129 -r1.130 src/sys/dev/raidframe/rf_reconstruct.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.