Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/tests/lib/libc/locale



Module Name:    src
Committed By:   kre
Date:           Tue Jun 30 05:24:11 UTC 2026

Modified Files:
        src/tests/lib/libc/locale: t_mbrtowc.c t_mbstowcs.c

Log Message:
PR lib/60369 Update tests to match modern UTF-8

This just removes test cases using invalid (by current standards) UTF-8
sequences (in one case the test is modified to switch it from invalid to valid)
The XFAIL that was added is removed.    ("removed" in all of this means
hashifd away).

There is, in this change, no attempt to fix either of the other very valid
concerns - actually testing invalid input to ensure it is rejected (would
need to be a whole new test case, the way they are currently structured is
not condusive to that - the input is simply known to be valid),  nor having
the test continue to try the remaining cases if an invalid result is obtained
rather than simply abandoning ship at the first opportunity.

Also note that none of this really has anything whatever to do with the
PR, which had nothing at all to do with what is valid UTF-8 and what is
not, but merely when something that is to be treated as invalid is
detetected, that MUST be reported, the (libc, not test) code must not
go on to examine further bytes and end up reporting that more are needed
(even if more would be needed were the input valid).   That is, when both
conditions exist, the error is reported, not the insufficient data.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/tests/lib/libc/locale/t_mbrtowc.c \
    src/tests/lib/libc/locale/t_mbstowcs.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index