Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/tests/libexec/ld.elf_so



Module Name:    src
Committed By:   riastradh
Date:           Thu Dec 18 05:27:02 UTC 2025

Modified Files:
        src/tests/libexec/ld.elf_so: Makefile

Log Message:
tests/libexec/ld.elf_so/Makefile: Undo recent -Wl,-Map change.

This was almost certainly a mistake in a commit that was otherwise
entirely about omap4/pandaboard support:

https://mail-index.NetBSD.org/source-changes/2025/12/16/msg159556.html

The change added LDADD linker arguments of the form

        -Wl,-Map foo.map

except that doesn't actually pass `-Map foo.map' through to the
underlying linker -- it only passes `-Map' to the linker, and then
treats `foo.map' as an extra input file for another object to link
(which doesn't work because the file doesn't exist).  If we want to
keep this change (not sure why), then we would have to use

        -Wl,-Map,foo.map

to actually pass `-Map foo.map' through to the underlying linker.

Should fix clang build failures:

    aarch64--netbsd-clang: error: no such file or directory: 't_ifunc.map'
    --- t_ifunc.link ---

    *** Failed target: t_ifunc.link
    *** In directory: /home/source/ab/HEAD-llvm/src/tests/libexec/ld.elf_so
    *** Failed commands:
            ${_MKTARGET_LINK}
            => @# "   link " ld.elf_so/t_ifunc.link
            ${_CCLINK.${:Ut_ifunc}}  ${_LDFLAGS.${:Ut_ifunc}} ${_LDSTATIC.${:Ut_ifunc}} -o ${.TARGET}  ${OBJS.${:Ut_ifunc}} ${_PROGLDOPTS} ${_LDADD.${:Ut_ifunc}}
            => /home/builds/ab/HEAD-llvm/evbarm-aarch64/20251217070550Z-tools/bin/aarch64--netbsd-clang    --sysroot=/home/builds/ab/HEAD-llvm/evbarm-aarch64/20251217070550Z-dest -Wl,--fatal-warnings 
-Wl,--warn-shared-textrel -Wl,-z,relro   -pie      -o t_ifunc.link  t_ifunc.o  -Wl,-rpath-link,/home/builds/ab/HEAD-llvm/evbarm-aarch64/20251217070550Z-dest/lib  -L=/lib     -Wl,-z,relro -Wl,-Map 
t_ifunc.map -Wl,-rpath,/usr/tests/libexec/ld.elf_so -lutil -latf-c
            ${CTFMERGE} ${CTFMFLAGS} -o ${.TARGET} ${OBJS.${:Ut_ifunc}}
            => /home/builds/ab/HEAD-llvm/evbarm-aarch64/20251217070550Z-tools/bin/nbctfmerge -t -g -L VERSION -g -o t_ifunc.link t_ifunc.o
    *** [t_ifunc.link] Error code 1


To generate a diff of this commit:
cvs rdiff -u -r1.33 -r1.34 src/tests/libexec/ld.elf_so/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index