CVS commit: xsrc/external/mit/xorg-server.old/dist/glx

["matthew green" <mrg%netbsd.org@localhost>]

Module Name:    xsrc
Committed By:   mrg
Date:           Sat Nov  2 23:49:48 UTC 2024

Modified Files:
        xsrc/external/mit/xorg-server.old/dist/glx: glxcmds.c

Log Message:
merge upstream change e5e8586a12a3ec915673edffa10dc8fe5e15dac3

Subject: [PATCH] glx: Call XACE hooks on the GLX buffer

The XSELINUX code will label resources at creation by checking the
access mode. When the access mode is DixCreateAccess, it will call the
function to label the new resource SELinuxLabelResource().

However, GLX buffers do not go through the XACE hooks when created,
hence leaving the resource actually unlabeled.

When, later, the client tries to create another resource using that
drawable (like a GC for example), the XSELINUX code would try to use
the security ID of that object which has never been labeled, get a NULL
pointer and crash when checking whether the requested permissions are
granted for subject security ID.

To avoid the issue, make sure to call the XACE hooks when creating the
GLX buffers.

Credit goes to Donn Seeley <donn%xmission.com@localhost> for providing the patch.

CVE-2024-0408


To generate a diff of this commit:
cvs rdiff -u -r1.1.1.1 -r1.2 \
    xsrc/external/mit/xorg-server.old/dist/glx/glxcmds.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.