CVS commit: src/tests/bin/sh

["Robert Elz" <kre%netbsd.org@localhost>]

Module Name:    src
Committed By:   kre
Date:           Fri Oct 18 09:05:23 UTC 2024

Modified Files:
        src/tests/bin/sh: t_fsplit.sh

Log Message:
Always run all sub-tests in a test case.

Previously, as soon as a sub-test in a test case failed,
the sub-test failed along with it, and no further sub-tests
were run, which would mean "fix one, run it again, fix
another, run it again, ...".   Now all the sub-tests that
fail are reported in each run.   Many of the other sh
ATF tests work the same way (approximately anyway).

This does mean that it is no longer possible to do (as was
once done here)

        atf_expect_fail "whatever reason"
        run_the_sub_test
        atf_expect pass

to allow for just one known sub-test to fail, and expect all
the others to work, as the individual sub-tests no longer atf_fail.

This change would have made no observable difference, as all
the sub-tests in all the test cases currently pass.

That's no fun!   So I added a new test case which contains a
bunch of sub-tests, some of which fail.   Don't bother attempting
to work out why, they fail because they were deliberately broken,
that is, broken in the test, not in sh.

Once this update has settled for a day or so, I'll remove that
new test case again (its sub-tests were simply stolen from other
test-cases, there's nothing new, and then some mangled, so they
fail).

While here, since there were (more or less rote) changes throughout,
some sh formatting style changes, 80-col, ..., slipped in as well.


To generate a diff of this commit:
cvs rdiff -u -r1.8 -r1.9 src/tests/bin/sh/t_fsplit.sh

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.