Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: [netbsd-10] src/sys/dev/pci



Module Name:    src
Committed By:   martin
Date:           Wed Sep 11 15:56:21 UTC 2024

Modified Files:
        src/sys/dev/pci [netbsd-10]: ehci_pci.c

Log Message:
Pull up following revision(s) (requested by rin in ticket #823):

        sys/dev/pci/ehci_pci.c: revision 1.77

ehci(4): properly handle failed attach

thinkpad a475 fails to attach an ehci instance:

    ehci0: pre-2.0 USB rev, device ignored

which ends up stopping suspend/resume working as the device has no
pmf handlers installed.  put most of the teardown code into a new
common function that is called from failed attach and detach.  if
attach fails, register NULL pmf handlers.  don't check the return
value of pmf_device_register*().

re-order several parts of detach to match the reverse attach order.
tested on rockpro64, thinkpad a475, and xps 1645, the a475 can now
suspend/resume almost fully successfully.


To generate a diff of this commit:
cvs rdiff -u -r1.75.2.1 -r1.75.2.2 src/sys/dev/pci/ehci_pci.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index