CVS commit: src/tests

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

Module Name:    src
Committed By:   riastradh
Date:           Fri Nov 24 17:31:03 UTC 2023

Modified Files:
        src/tests/fs/hfs: t_pathconvert.c
        src/tests/kernel: t_memfd_create.c
        src/tests/lib/librefuse: t_refuse_opt.c
        src/tests/lib/librumpclient: t_fd.c

Log Message:
tests: Audit RZ abuse.

RZ succeeds if x is zero, and fails if x is nonzero, treating a
nonzero value as a error number as in errno(3) to print the message.

The following library routines instead return -1 on failure and set
errno to the error code:

fuse_opt_add_arg
fuse_opt_add_opt
fuse_opt_add_opt_escaped
fuse_opt_insert_arg
lseek
system

So use RL instead for those -- succeeds if x is zero, and fails if x
is -1.

This shouldn't make any tests newly fail or newly succeed -- the
functions in question only ever return 0 or -1 -- but if the tests
were already failing anywhere, they will now fail with meaningful
messages.

TBD: dlinfo, which isn't fit for RL or RZ since it reports errors via
dlerror() rather than errno.


To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 src/tests/fs/hfs/t_pathconvert.c
cvs rdiff -u -r1.2 -r1.3 src/tests/kernel/t_memfd_create.c
cvs rdiff -u -r1.9 -r1.10 src/tests/lib/librefuse/t_refuse_opt.c
cvs rdiff -u -r1.8 -r1.9 src/tests/lib/librumpclient/t_fd.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.