CVS commit: src

["matthew green" <mrg%netbsd.org@localhost>]

Module Name:    src
Committed By:   mrg
Date:           Tue Aug  1 08:47:25 UTC 2023

Modified Files:
        src/bin/rcp: rcp.c
        src/crypto/external/bsd/openssh/dist: scp.c
        src/lib/libc/net: getaddrinfo.c
        src/lib/libc/resolv: res_debug.c res_query.c
        src/usr.sbin/edquota: edquota.c
        src/usr.sbin/ypserv/common: ypdb.c

Log Message:
convert explicit length check before unchecked snprintf() with just a
overflow checked snprintf().  for res_debug.c and res_query.c, convert
from sprintf() to snprintf().

tested scp and rcp fail properly with too-long paths.
tested getaddrinfo fails as expected for too-long domains.
tested dig and ping for similar (res_debug.c/res_query.c).
created a temporary fs with quotas to test edquota with a long EDITOR.
did not test ypserv directly, but it's the same pattern.

avoids GCC 12 snprintf() warnings, and reduces total code size.


To generate a diff of this commit:
cvs rdiff -u -r1.52 -r1.53 src/bin/rcp/rcp.c
cvs rdiff -u -r1.38 -r1.39 src/crypto/external/bsd/openssh/dist/scp.c
cvs rdiff -u -r1.123 -r1.124 src/lib/libc/net/getaddrinfo.c
cvs rdiff -u -r1.16 -r1.17 src/lib/libc/resolv/res_debug.c \
    src/lib/libc/resolv/res_query.c
cvs rdiff -u -r1.53 -r1.54 src/usr.sbin/edquota/edquota.c
cvs rdiff -u -r1.12 -r1.13 src/usr.sbin/ypserv/common/ypdb.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.