CVS commit: src/usr.bin/make

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    src
Committed By:   rillig
Date:           Sat Jan 30 20:53:29 UTC 2021

Modified Files:
        src/usr.bin/make: buf.c buf.h cond.c dir.c for.c main.c parse.c var.c

Log Message:
make(1): split Buf_Destroy into Buf_Done and Buf_DoneData

In all cases except one, the boolean argument to Buf_Destroy was
constant.  Removing that argument by splitting the function into two
separate functions makes the intention clearer on the call site.  It
also removes the possibility for using the return value of Buf_Done,
which would have made no sense.

The function Buf_Done now pairs with Buf_Init, just as in HashTable and
Lst.

Even though Buf_Done is essentially a no-op, it is kept as a function,
both for symmetry with Buf_Init and for clearing the Buffer members
after use (this will be done only in CLEANUP mode, in a follow-up
commit).


To generate a diff of this commit:
cvs rdiff -u -r1.47 -r1.48 src/usr.bin/make/buf.c
cvs rdiff -u -r1.38 -r1.39 src/usr.bin/make/buf.h
cvs rdiff -u -r1.253 -r1.254 src/usr.bin/make/cond.c
cvs rdiff -u -r1.264 -r1.265 src/usr.bin/make/dir.c
cvs rdiff -u -r1.138 -r1.139 src/usr.bin/make/for.c
cvs rdiff -u -r1.517 -r1.518 src/usr.bin/make/main.c
cvs rdiff -u -r1.533 -r1.534 src/usr.bin/make/parse.c
cvs rdiff -u -r1.783 -r1.784 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.