CVS commit: [netbsd-9] src/sys

["Martin Husemann" <martin%netbsd.org@localhost>]

Module Name:    src
Committed By:   martin
Date:           Wed Dec 23 12:34:38 UTC 2020

Modified Files:
        src/sys/dev/usb [netbsd-9]: ehci.c ohci.c uhci.c xhci.c
        src/sys/external/bsd/dwc2 [netbsd-9]: dwc2.c

Log Message:
Pull up following revision(s) (requested by riastradh in ticket #1159):

        sys/dev/usb/ohci.c: revision 1.314
        sys/external/bsd/dwc2/dwc2.c: revision 1.75
        sys/dev/usb/ehci.c: revision 1.284
        sys/dev/usb/uhci.c: revision 1.305
        sys/dev/usb/xhci.c: revision 1.136

usb: Omit bogus assertions about struct usbd_pipe::up_intrxfer.

These assertions were only valid for pipes at UE_IN_DIR, UE_INTERRUPT
endpoints created with usbd_open_pipe_intr, which uses up_intrxfer to
pass the struct usbd_xfer object to usbd_close_pipe to free later.

In contrast, for pipes at UE_OUT_DIR, UE_INTERRUPT endpoints,
up_intrxfer is never initialized, so the assertion cannot be right.
In principle we might even have more than one outstanding interrupt
transfer at a time, rendering the point of the assertion moot anyway.

Found by interrupting a uhidev write to a u2f device.

ok nick


To generate a diff of this commit:
cvs rdiff -u -r1.267.2.3 -r1.267.2.4 src/sys/dev/usb/ehci.c
cvs rdiff -u -r1.289.4.6 -r1.289.4.7 src/sys/dev/usb/ohci.c
cvs rdiff -u -r1.288.4.2 -r1.288.4.3 src/sys/dev/usb/uhci.c
cvs rdiff -u -r1.107.2.6 -r1.107.2.7 src/sys/dev/usb/xhci.c
cvs rdiff -u -r1.59.4.3 -r1.59.4.4 src/sys/external/bsd/dwc2/dwc2.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.