Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/sys



Module Name:    src
Committed By:   christos
Date:           Wed Oct 16 15:27:39 UTC 2019

Modified Files:
        src/sys/kern: kern_core.c kern_hook.c kern_sig.c kern_veriexec.c
            subr_ipi.c subr_pool.c subr_vmem.c sys_ptrace_common.c
        src/sys/net: if_ethersubr.c

Log Message:
Add void * function pointer casts. There are different ways to "fix" those
warnings:
    1. this one: add a void * cast (which I think is the least intrusive)
    2. add pragmas to elide the warning
    3. add intermediate inline conversion functions
    4. change the called function prototypes, adding unused arguments and
       converting some of the pointer arguments to void *.
    5. make the functions varyadic (which defeats the purpose of checking)
    6. pass command line flags to elide the warning
I did try 3 and 4 and I was not pleased with the result (sys_ptrace_common.c)
(3) added too much code and defines, and (4) made the regular use clumsy.


To generate a diff of this commit:
cvs rdiff -u -r1.24 -r1.25 src/sys/kern/kern_core.c
cvs rdiff -u -r1.6 -r1.7 src/sys/kern/kern_hook.c
cvs rdiff -u -r1.373 -r1.374 src/sys/kern/kern_sig.c
cvs rdiff -u -r1.20 -r1.21 src/sys/kern/kern_veriexec.c
cvs rdiff -u -r1.5 -r1.6 src/sys/kern/subr_ipi.c
cvs rdiff -u -r1.259 -r1.260 src/sys/kern/subr_pool.c
cvs rdiff -u -r1.97 -r1.98 src/sys/kern/subr_vmem.c
cvs rdiff -u -r1.67 -r1.68 src/sys/kern/sys_ptrace_common.c
cvs rdiff -u -r1.278 -r1.279 src/sys/net/if_ethersubr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index