CVS commit: [netbsd-8] src

["Martin Husemann" <martin%netbsd.org@localhost>]

Module Name:    src
Committed By:   martin
Date:           Mon Jul  8 16:30:58 UTC 2019

Modified Files:
        src/sys/netinet6 [netbsd-8]: nd6.c
        src/tests/net/ndp [netbsd-8]: t_ndp.sh

Log Message:
Pull up following revision(s) (requested by ozaki-r in ticket #1285):

        sys/netinet6/nd6.c: revision 1.255
        tests/net/ndp/t_ndp.sh: revision 1.32

nd6: restore a missing reachability confirmation

On sending a packet over a STALE cache, the cache should be tried a reachability
confirmation, which is described in RFC 2461/4861 7.3.3.  On the fast path in
nd6_resolve, however, the treatment for STALE caches has been skipped
accidentally.  So STALE caches never be back to the REACHABLE state.

To fix the issue, branch to the fast path only when the cache entry is the
REACHABLE state and leave other caches to the slow path that includes the
treatment.  To this end we need to allow to return a link-layer address if a
valid address is available on the slow path too, which is the same behavior as
FreeBSD and OpenBSD.

tests: test state transitions of neighbor caches


To generate a diff of this commit:
cvs rdiff -u -r1.232.2.9 -r1.232.2.10 src/sys/netinet6/nd6.c
cvs rdiff -u -r1.19.2.2 -r1.19.2.3 src/tests/net/ndp/t_ndp.sh

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.