Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/sys/dev/mii



Module Name:    src
Committed By:   msaitoh
Date:           Fri Dec 28 06:20:32 UTC 2018

Modified Files:
        src/sys/dev/mii: makphy.c makphyreg.h
Removed Files:
        src/sys/dev/mii: e1000phyreg.h

Log Message:
- Backout some changes done in rev. 1.44. OK'd by jdolecek@:
  - Remove e1000phyreg.h and use makphyreg.h again.
  - Remove Energy detect stuff. Leave it by default.
  - Remove MDI crossover configuraton. Leave it by default. I think it's OK to
    add new API to change the mode.
  - PHY_RESET() is used to commit some changes, so I think it's not good to
    always clear BMCR_AUTOEN before reset in makphy_reset().
  - It's not required to read MII_100T2SR twice because this register has no
    any bit which is latched.
- Use mii_phy_reset() instead of extracted code.
- Don't set PSCR_CRS_ON_TX on newer. Those chips have no this bit.
- Add some "XXX FIXME" comment. Non GMII mode uses different page except
  very old chip. Some bits are at the same location but others are not.
- Remove obsolete comment.
- s/MII_MAKPHY_/MAKPHY_/

XXX rev. 1.44 changed the setting of mii_media_active when the interface is
set to other than auto. I suspect the intention of the change is to reflect
the link up/down status. But, it didn't work because non auto setting makes
PSSR_LINK bit alwasy set "without modifing some registers".
This commit won't fix the change and it'll be fixed in the next commit.


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r0 src/sys/dev/mii/e1000phyreg.h
cvs rdiff -u -r1.45 -r1.46 src/sys/dev/mii/makphy.c
cvs rdiff -u -r1.8 -r1.9 src/sys/dev/mii/makphyreg.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index