CVS commit: src/sys/fs/puffs

["Emmanuel Dreyfus" <manu%netbsd.org@localhost>]

Module Name:    src
Committed By:   manu
Date:           Tue Nov  4 09:10:37 UTC 2014

Modified Files:
        src/sys/fs/puffs: puffs_node.c puffs_vnops.c

Log Message:
Fix PUFFS node use-after-reclaim

When puffs_cookie2vnode() misses an entry, vcache_get()
creates a new node (puffs_vfsop_loadvnode being called to
initialize the PUFFS part), then it discovers it is VNON,
and tries to vrele() it. vrele() calls VOP_INACTIVE(),
which led us in puffs_vnop_inactive() where we sent a
request to the filesystem for a node that already had been
reclaimed.

The fix is to check for VNON nodes in puffs_vnop_inactive()
and to return without doing anyting. This is suboptimal, but
a better workaround would probably need to modify vcache API,
with an impact on other filesystems. Let us keep it simple.


To generate a diff of this commit:
cvs rdiff -u -r1.34 -r1.35 src/sys/fs/puffs/puffs_node.c
cvs rdiff -u -r1.196 -r1.197 src/sys/fs/puffs/puffs_vnops.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.