CVS commit: src

["David A. Holland" <dholland%netbsd.org@localhost>]

Module Name:    src
Committed By:   dholland
Date:           Sat Jun 28 22:27:51 UTC 2014

Modified Files:
        src/lib/libquota: quota_kernel.c
        src/sys/compat/netbsd32: netbsd32.h netbsd32_netbsd.c
        src/sys/kern: vfs_quotactl.c vfs_syscalls.c
        src/sys/sys: mount.h quotactl.h
        src/sys/ufs/lfs: ulfs_quota.c ulfs_quota.h ulfs_quota2.c
        src/sys/ufs/ufs: ufs_quota.c ufs_quota.h ufs_quota2.c

Log Message:
Revert the following changes:

   src/sys/sys/quotactl.h 1.37
   src/sys/compat/netbsd32/netbsd32.h 1.101
   src/sys/compat/netbsd32/netbsd32_netbsd.c 1.188, 1.189
   src/sys/kern/vfs_quotactl.c 1.39
   src/sys/kern/vfs_syscalls.c 1.483
   src/sys/ufs/lfs/ulfs_quota.c 1.11
   src/sys/ufs/ufs/ufs_quota.c 1.116
   src/lib/libquota/quota_kernel.c 1.5

and do them correctly.

If you're going to change the name of something, you need to change
the name of *all* the things with the same name, not just a handful,
and you should change it to something similar so it still matches the
rest of the system rather than just picking an arbitrarily different
name.

Hi, Joerg.

To wit, rename the quotactl "delete" operation to "del", because
"delete" is a reserved word in C++ and for some reason Joerg wants to
run internal interfaces used only by C code through his C++ compiler.
Do not rename it to "remove" instead, because this doesn't match
libquota or the rest of the usage throughout the system; and rename
all the related identifiers, not just the ones that blew the mind of
Joerg's C++ compiler.

Because this is not a user-facing API (the only userland consumer
sys/quotactl.h is libquota) it is sort of ok to make arbitrary
source-incompatible changes; however, by the same token it's completely
unnecessary. If it *were* a user-facing API that someone might have a
semi-rational reason to want to run a C++ compiler on, it would be
incorrect to change it at this point.


To generate a diff of this commit:
cvs rdiff -u -r1.5 -r1.6 src/lib/libquota/quota_kernel.c
cvs rdiff -u -r1.101 -r1.102 src/sys/compat/netbsd32/netbsd32.h
cvs rdiff -u -r1.191 -r1.192 src/sys/compat/netbsd32/netbsd32_netbsd.c
cvs rdiff -u -r1.39 -r1.40 src/sys/kern/vfs_quotactl.c
cvs rdiff -u -r1.485 -r1.486 src/sys/kern/vfs_syscalls.c
cvs rdiff -u -r1.214 -r1.215 src/sys/sys/mount.h
cvs rdiff -u -r1.37 -r1.38 src/sys/sys/quotactl.h
cvs rdiff -u -r1.11 -r1.12 src/sys/ufs/lfs/ulfs_quota.c
cvs rdiff -u -r1.4 -r1.5 src/sys/ufs/lfs/ulfs_quota.h
cvs rdiff -u -r1.15 -r1.16 src/sys/ufs/lfs/ulfs_quota2.c
cvs rdiff -u -r1.116 -r1.117 src/sys/ufs/ufs/ufs_quota.c
cvs rdiff -u -r1.21 -r1.22 src/sys/ufs/ufs/ufs_quota.h
cvs rdiff -u -r1.38 -r1.39 src/sys/ufs/ufs/ufs_quota2.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.