CVS commit: othersrc/crypto/external/bsd/ssss/dist/src

["Alistair G. Crooks" <agc%netbsd.org@localhost>]

Module Name:    othersrc
Committed By:   agc
Date:           Sat Feb 18 02:17:42 UTC 2012

Modified Files:
        othersrc/crypto/external/bsd/ssss/dist/src/libssss: secsplit.c
            threshold.c
        othersrc/crypto/external/bsd/ssss/dist/src/ssss: main.c

Log Message:
Various fixes to improve stability and code readability

+ previously not enough space was allocated for the unusual occurrence that
a 16-bit entity was greater than the largest 16bit prime (65521). Introduce
an overhead allocation which works around this issue

+ the largest prime is not about to change - define it, and don't bother
passing it as an argument to functions.

+ remove an extraneous "can't happen" call to exit()

+ fix some lint (as seen on amd64)

+ use better names for variables in the code

+ move occurrences of fprintf() to warn() - thanks, Christos!

+ use definitions instead of magic integer constants to make it obvious
what's happening with end of file, and odd-sized files

+ hold on information on input parsing in a separate struct, rather than
using arguments to functions

+ check input arguments to ssss(1), and improve error checking in general

With this in place, ssss(1) will now combine shares accessible through
httpdev(8) - which opens up a number of opportunities...


To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 \
    othersrc/crypto/external/bsd/ssss/dist/src/libssss/secsplit.c
cvs rdiff -u -r1.2 -r1.3 \
    othersrc/crypto/external/bsd/ssss/dist/src/libssss/threshold.c
cvs rdiff -u -r1.1.1.1 -r1.2 \
    othersrc/crypto/external/bsd/ssss/dist/src/ssss/main.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.