Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/postinstall



On Fri, Feb 27, 2009 at 12:06:53AM +0000, Jonathan Perkin wrote:
> * On 2009-02-26 at 21:41 GMT, Christos Zoulas wrote:
> 
> > In article <20090226205144.GC5639%apb-laptoy.apb.alt.za@localhost> Alan
> > Barrett  <apb%cequrux.com@localhost> wrote:
> >
> > > On Thu, 26 Feb 2009, Christos Zoulas wrote:
> > >
> > > > > "grep -q" is not portable; use "grep >/dev/null" instead.
> > > > > Also add a comment saying that postinstal is invoked during a
> > > > > cross build.
> > > > 
> > > > I beg to differ, which grep does not have -q? If so it is not
> > > > POSIX compliant.
> > >
> > > Solaris.
> > 
> > Even the xpg4 version?
> 
> It does, but then you have to add faff to the script to find the right
> grep.

And why do you even need to use grep at all?  Is case and awk not enough
for the simple stuff in the script?

-- 
-- Lubomir Sedlacik <salo@{NetBSD,Xtrmntr,silcnet}.org>   --


Home | Main Index | Thread Index | Old Index