Re: CVS commit: src/sys/arch/x86/x86

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

David Young wrote:
> On Thu, Feb 19, 2009 at 11:34:14PM +0000, Christoph Egger wrote:
>> Module Name: src
>> Committed By:        cegger
>> Date:                Thu Feb 19 23:34:14 UTC 2009
>>
>> Modified Files:
>>      src/sys/arch/x86/x86: bus_dma.c
>>
>> Log Message:
>> bus_dmamap_create(): on failure, reset dmamp or drivers
>> like nfe(4) try to call bus_dmamap_destroy() on an invalid dmamap in their 
>> error path.
> 
> Christoph,
> 
> Please, back this change out and fix the drivers, instead.

I tried that for nfe.
In nfe_alloc_tx_ring(), setting ring->map = NULL right before
'goto fail;' has no effect.
In nfe_free_tx_ring() it calls bus_dmamap_destroy(), nonetheless then.

Further, bus_dma(9) manpage is not clear about the parameters if they
are intended to be NULL or undefined in error case.
manpage just says, bus_dmamap_create returns non-zero in failure case.