Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/sys

On Thu, Jan 29, 2009 at 09:05:50PM +0000, Matthias Drochner wrote:

> Module Name:  src
> Committed By: drochner
> Date:         Thu Jan 29 21:05:50 UTC 2009
> Modified Files:
>       src/sys/sys: types.h
> Log Message:
> Revert change of rlim_t to an unsigned quad_t which crept in in the
> time_t merge. This has bad effects on comparisions in the kernel
> leading to processes randomly killed for RLIMIT_CPU violation.
> (There are situations where the CPU time used can drop below 0, if
> the time is changed by ntp. This is certainly not good but this is
> a minor issue we obviously could live with and which is not related
> to the time_t size change.)

I remember seeing a number of comparisons against rlim_t that were modified
with the time_t diff. They looked to be handling signed/unsigned issues.
Those also need to be restored otherwise we may have a security issue.


Home | Main Index | Thread Index | Old Index