Re: CVS commit: src/crypto/external/bsd/openpgpsdk/dist

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sat, Jan 24, 2009 at 12:51:12PM +0000, Havard Eidnes wrote:
> 
> Module Name:  src
> Committed By: he
> Date:         Sat Jan 24 12:51:12 UTC 2009
> 
> Modified Files:
>       src/crypto/external/bsd/openpgpsdk/dist/include/openpgpsdk: crypto.h
>       src/crypto/external/bsd/openpgpsdk/dist/src/lib: symmetric.c
> 
> Log Message:
> No, our openssl _encrypt routines do not take a *size_t as the 6th
> argument, they take an *int, and those are not necessarily compatible.
> Papering that over with a cast just gets us a warning that
> de-referencing a type-punned pointer will break strict-aliasing
> rules, which is turned into an error by our WARNS setting.
> 
> Instead, change the "num" field in _opt_crypt_t from size_t to int, and
> get rid of the now-redundant casts.

Interesting, thanks.  It's not an i386, so what platform was this on?  I
wonder if it's an issue with the age of some of the openpgpsdk code -
this argument changed type in openssl some time ago, IIRC?

The casts are in the original vendor branch code; I've been feeding back
our patches, and I'll feed this one back, too. I trust Ben Laurie to be
intimate with the openssl code, somehow, so we'll see what he says :-).

Regards,
Alistair