[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/dev/pci
> > BTW, what made you use PAGE_SIZE to adjust new mbufs?
> We don't have ETHER_ALIGN, therefore I searched for a
> replacement that was most reasonable for me.
If you really thought PAGE_SIZE was most reasonable,
I'd suggest to call for review before committing
code by such mechanical replacements without any tests.
ETHER_ALIGN means "roundup(ETHER_HDR_LEN, 4) - ETHER_HDR_LEN"
to make trailing received data word aligned, and
PAGE_SIZE is definitely larger than MCLSIZE.
Main Index |
Thread Index |