Re: CVS commit: src/sys/dev/wscons

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

hi,

> On Jan 16, 11:06am, yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
> -- Subject: Re: CVS commit: src/sys/dev/wscons
> 
> | > Don't you want:
> | > 
> | >   #if defined(COMPAT_50) || defined(MODULAR)
> | >   ev->version = 0;
> | > + #else
> | > + ev->version = WSCONS_EVENT_VERSION;
> | >   #endif /* defined(COMPAT_50) || defined(MODULAR) */
> | > 
> | > 
> | > Or something?
> | > 
> | > christos
> | 
> | i don't think it's a good idea to change the behaviour depending on
> | configurations, given that any 5.0 applications needs to do an explicit
> | SETVERSION anyway.
> | 
> | (sorry for forgetting to mention it in the commit log.)
> 
> So ev->version gets set to what by default (is the structure 0'ed or does
> it get a random variable)? Let's say I don't have COMPAT_50, if the app
> does not do SETVERSION, what does it get?
> 
> christos

hm, it will use the value left by the previous user the device.
(as the previous version does. :)
it isn't what i intended.  ie. bug.

YAMAMOTO Takashi