Re: CVS commit: src/sys/dev/wscons

[yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi)]

hi,

> In article <20090115042211.6EFF6175D0%cvs.netbsd.org@localhost>,
> YAMAMOTO Takashi  <yamt%netbsd.org@localhost> wrote:
> >
> >Module Name: src
> >Committed By:        yamt
> >Date:                Thu Jan 15 04:22:11 UTC 2009
> >
> >Modified Files:
> >     src/sys/dev/wscons: wsdisplay.c wsevent.c wseventvar.h wskbd.c
> >         wsmouse.c wsmux.c
> >
> >Log Message:
> >- reduce the number of #ifdefs.
> >- build compat glues if MODULAR.
> 
> Thanks!
> 
> Don't you want:
> 
>   #if defined(COMPAT_50) || defined(MODULAR)
>       ev->version = 0;
> + #else
> +     ev->version = WSCONS_EVENT_VERSION;
>   #endif /* defined(COMPAT_50) || defined(MODULAR) */
> 
> 
> Or something?
> 
> christos

i don't think it's a good idea to change the behaviour depending on
configurations, given that any 5.0 applications needs to do an explicit
SETVERSION anyway.

(sorry for forgetting to mention it in the commit log.)

YAMAMOTO Takashi