Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.sbin/videomode

On Wed, 14 Jan 2009, Havard Eidnes wrote:
> Modified Files:
>       src/usr.sbin/videomode: videomode.c
> Log Message:
> Add a cast to make this build again (no sense in doing PRIu64 when we
> & with 7 right after).

I think that you are invoking undefined behaviour, casting a value to
(int) when the value might conceivably be larger than INT_MAX.  If you
cast to (unsigned int) instead, then all should be well.

--apb (Alan Barrett)

Home | Main Index | Thread Index | Old Index