Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/ufs/ffs

On Thu, Dec 25, 2008 at 5:31 PM, Christoph Egger 
<> wrote:
> Arnaud Lacombe wrote:
>> On Tue, Dec 23, 2008 at 6:32 AM, Christoph Egger 
>> <> wrote:
>>> Module Name:    src
>>> Committed By:   cegger
>>> Date:           Tue Dec 23 11:32:08 UTC 2008
>>> Modified Files:
>>>        src/sys/ufs/ffs: ffs_inode.c
>>> Log Message:
>>> ffs_update: sprinkle KASSERTs
>> didn't <ad> object on this[0] ?
> He objected the real functional change I showed in the diff
> to ffs_vnops.c.
we have different interpretation of his mail then.

Anyway, this doesn't explain the underlying reason for the KASSERT()
you added. This may be obvious, but more details in the commit log
would better. The diff itself is enough to understand you added
KASSERT, it doesn't explain *why*. Note that I'm also very doubtfull
on the usefullness of these KASSERT() (unless you give a clear
explanation of course).

btw, don't test pointer truth, do the test against NULL. Setting NULL
to something else than 0 would be really fun :/

 - Arnaud

Home | Main Index | Thread Index | Old Index