Re: CVS commit: src/sys

[Andrew Doran <ad%netbsd.org@localhost>]

On Wed, Dec 03, 2008 at 03:31:00PM +0000, Christos Zoulas wrote:
> In article <20081203125111.BB8F8175D0%cvs.netbsd.org@localhost>,
> Andrew Doran  <ad%netbsd.org@localhost> wrote:
> >
> >Module Name: src
> >Committed By:        ad
> >Date:                Wed Dec  3 12:51:11 UTC 2008
> >
> >Modified Files:
> >     src/sys/compat/linux/common: linux_oldmmap.c
> >     src/sys/compat/linux32/common: linux32_mod.c
> >     src/sys/modules/compat_linux32: Makefile
> >
> >Log Message:
> >PR port-amd64/40091 compat_linux32 module loading = panic due to missing syms
> 
> If the kernel can't resolve all the symbols, shouldn't the kernel unload the
> module?

That happens.

The PR is unclear. I didn't have time to investigate the panic but I'm
guessing it is the other way around: text/data from compat_netbsd32 is in
use by compat_linux32, but there was no dependency recorded, so netbsd32
could be unloaded while linux32 was still resident.

An option would be to add code to the symbol lookup to check that symbols
we find are in modules recorded as required or are in 'netbsd'. It would
need to be quick or conditional.

Andrew