Re: CVS commit: src/usr.sbin/cpuctl

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

Mindaugas Rasiukevicius wrote:
> Christoph Egger <Christoph_Egger%gmx.de@localhost> wrote:
>> Mindaugas Rasiukevicius wrote:
>>> Module Name:        src
>>> Committed By:       rmind
>>> Date:               Wed Nov 19 11:05:40 UTC 2008
>>>
>>> Modified Files:
>>>     src/usr.sbin/cpuctl: cpuctl.c
>>>
>>> Log Message:
>>> cpu_identify: check ID against number of processors.
>>> Fix for PR/39955.
>> getcpuid() is used for the other commands as well.
>> The check should be there as I proposed in the PR.
> 
> Other commands (that is online/offline) would fail on syscalls if value is
> invalid.

This is right. But the resulting error message is not that clear to the
user as it should be.

> Purpose of the getcpuid() seemed to be just extract the number.
> Anyway, I do not mind changing this.

So you're fine with the diff I proposed in the PR ?

Christoph