Source-Changes archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/dev/pci
On Mar 2, 11:04am, Christos Zoulas wrote:
} In article <20081114215402.GB10928%britannica.bec.de@localhost>,
} Joerg Sonnenberger <joerg%britannica.bec.de@localhost> wrote:
} >On Fri, Nov 14, 2008 at 09:44:45PM +0000, Christos Zoulas wrote:
} >> Why not save it in ram only on and during suspend? Is there an ordering
} >> issue again because the disk might have already been suspended? Should
} >> we add a "prepare to suspend" pass to avoid all the ordering issues?
} >
} >What do we want to optimise for? Seriously, wpi is using the same
} >approach to wifi as ~every other device does. Keep the firmware in
} >memory for whenever you will need it.
} >
} >Note that this is not only resume time, but it will load the firmware
} >whenever if_init is called. If you really worry about the memory usage,
} >the static bus dma allocation should be eliminated first. That is larger
} >than the size of the firmware. But I don't think worrying about the
} >150KB image is justified.
}
} It is still 13% of the memory on a 2GB machine.
This is rather interesting math.
150KB = 153,600 bytes
2GB = 2,147,483,648 bytes
divide the two and you get .000071525
times 100 and you .0071525 per cent
You seem to be off by a few decimal points. However, I still agree
that it is a rather large waste of memory. A far better idea would be
to fix suspend/resume to either bring up the disks first or to postpone
the loading of firmware until after everything else is done.
}-- End of excerpt from Christos Zoulas
Home |
Main Index |
Thread Index |
Old Index