Re: CVS commit: src/sys

[David Young <dyoung%pobox.com@localhost>]

On Tue, Nov 11, 2008 at 11:43:48AM +0000, Martin Husemann wrote:
> On Mon, Nov 10, 2008 at 04:28:53PM -0600, David Young wrote:
> > Can you get a backtrace at this printf?
> 
> I don't understand why you added this call to ifioctl_common - we can either
> remove it again, or seriously rework the surrounding code to not do the 
> if_up()
> resp. if_down() [open coded] - but doing it twice is bad.

I added the call to ifioctl_common() to sppp_ioctl() because I removed
it from ifioctl() at the same time:

@@ -1648,47 +1661,13 @@ ifioctl(struct socket *so, u_long cmd, v
        }
 
        oif_flags = ifp->if_flags;
-       switch (cmd) {
-
-       case SIOCSIFFLAGS:
-               ifioctl_common(ifp, cmd, data);
-               if (ifp->if_ioctl)
-                       (void)(*ifp->if_ioctl)(ifp, cmd, data);
-               break;
-

The only difference that I see is that ifioctl_common() used to run
before the code in pppoe_ioctl() and sppp_ioctl(); now, a little bit of
code in pppoe_ioctl() runs before ifioctl_common().

> If you want to keep the call, I can handle the adaption of the code - but
> easiest solution is to just remove the call IMHO.

I want for pppoe(4) to work again, first of all, but I also want to
share code where possible.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933 ext 24