Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: src/sys



Module Name:    src
Committed By:   tls
Date:           Sat Oct 11 16:39:07 UTC 2008

Modified Files:
        src/sys/conf: files
        src/sys/kern: uipc_accf.c uipc_socket.c

Log Message:
Address problems with accept filters noted by ad in his source-changes
mail: http://mail-index.netbsd.org/source-changes/2008/10/10/msg211109.html

        * Scary-looking socket locking stubs (changed to KASSERT of locked)

        * depends on INET inappropriately (though now you must add new
          accept filter names to the uipc_accf.c line in conf/files if
          you aren't using dataready or httpready)

        * New code uses MALLOC/FREE -- changed to kmem_alloc/kmem_free;
          could be pool_cache, these are all fixed-size allocations.

We need to verify that this works as expected with protocols with per-socket
locking, like PF_LOCAL.  I'm a little concerned about the case where the
lock on the listen socket isn't the same lock as on the eventual connected
socket.


To generate a diff of this commit:
cvs rdiff -r1.920 -r1.921 src/sys/conf/files
cvs rdiff -r1.3 -r1.4 src/sys/kern/uipc_accf.c
cvs rdiff -r1.174 -r1.175 src/sys/kern/uipc_socket.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.



Home | Main Index | Thread Index | Old Index