Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/arch/macppc/dev



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Sep 10, 2008, at 10:34 AM, Marco Trillo wrote:

Hi,

On Wed, Sep 10, 2008 at 2:57 PM, Michael Lorenz <macallan%netbsd.org@localhost> wrote:
Gah, I'm blind - didn't look deep enough. I'll fix that.
( Doesn't really matter since we don't really map anything but for
correctness' sake I'll change it back. Tim's new bus_space code which
actually keeps track of bus_space_map()s exposed a whole bunch of cases where drivers mapped way too much address space, overlapped with other drivers' mappings and subsequently got rejected and stopped working. This
looked like another case like that. )

In fact obio.c already maps its own space for FCRs and GPIOs:

171: error = bus_space_map (pa->pa_memt, ca.ca_baseaddr, 0x80, 0, &bsh);

So it looks like the mapping done in if_wi_obio.c overlaps with the
mapping done in obio.c; don't known if this causes problems.

If someone else already mapped (parts of) the range subsequent attempts will fail.

Maybe if_wi_obio should be mapping only its own baseaddr + 0x1a000,
length 0x100 space and using the common obio map for FCRs and GPIOs.

Yeah, obio should provide an interface for messing with the FCR and such.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBSMiiAMpnzkX8Yg2nAQLcIgf/c2iFZmpLEq4gPyQU2FF8b7YIfFAPYO/s
45yFgbNCRBykYI6GHNLEGqRdLiUJPhOo6KfflCNL/ejmH3Fph/aggz5/HMD/vBsf
tKzMcVJPdT6IcXhlrzLb43RruAFr2g2xY29RI5YghH2VgB5rg4SpDVxSLHkUZqem
nJKOumpFAoyQfCtd7ldvaXsg+dnm+VpG8ple33KZTN4OsmUh8UQDixWvgY4Gmn8z
jj7cjCO7Qx1SSEoeKYlwW9wQmiKKebi7dCHFdws8Mu3enQa99Iovo5MDl1tPnKBv
Z3ZGMmLIV58EeR6fwdjDTBw/txT3nVHWtm+fxuHaUXv64zZn2CoxTA==
=LSo3
-----END PGP SIGNATURE-----


Home | Main Index | Thread Index | Old Index