Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/i2c



On Tue, 26 Aug 2008, Jared D. McNeill wrote (on source-changes list):

... the existing i2c code includes a bus scan to
enumerate the devices on the bus, however this loop is currently
#ifdef'd out.  It is unclear (to me, at least) if this enumeration
has ever been tested, or if it's probing of bus addresses is both
reliable and non-intrusive;  I have to assume that it was #ifdef'd
out for a reason.  ...

It was causing hangs at boot on some machines and erratic behaviour on others, which was why it was disabled.

Would it make sense to conditionally enable this code, perhaps via an

        options I2C_SCAN

or maybe add a flag "locator" to i2c ?


----------------------------------------------------------------------
|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |  paul%whooppee.com@localhost   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette%juniper.net@localhost |
----------------------------------------------------------------------


Home | Main Index | Thread Index | Old Index