Re: CVS commit: src

[Wolfgang Solfrank <Wolfgang%Solfrank.net@localhost>]

Hi,

Darren Reed wrote:
> cvs rdiff -r1.36 -r1.37 src/sys/dist/ipf/netinet/ip_nat.c

Hmm, this has an interesting number of bugs in just one statement ;-)

                                port = ipf_random() % (ntohs(np->in_pmax) -
                                                       ntohs(np->in_pmin));

I think what you meant here is something like:

                                port = ntohs(ipf_random() % (np->in_pmax - 
np->in_pmin)
                                             + np->in_pmin);

i.e., the placement of ntohs is wrong, plus the offset of the port number is 
missing.

Ciao,
Wolfgang
--
Wolfgang%Solfrank.net@localhost