Re: CVS commit: src/sys

[Bernd Ernesti <veego%NetBSD.org@localhost>]

On Thu, Jul 10, 2008 at 12:34:43AM +0200, Christoph Egger wrote:
> David Young wrote:
> >On Wed, Jul 09, 2008 at 07:47:24PM +0000, Joerg Sonnenberger wrote:
> >>Module Name:        src
> >>Committed By:       joerg
> >>Date:               Wed Jul  9 19:47:24 UTC 2008
> >>
> >>Modified Files:
> >>    src/sys/arch/mips/atheros/dev: if_ath_arbus.c
> >>    src/sys/dev/cardbus: if_ath_cardbus.c
> >>    src/sys/dev/ic: ath.c ath_netbsd.c athrate-sample.c athvar.h
> >>    src/sys/dev/pci: if_ath_pci.c
> >>
> >>Log Message:
> >>- device/softc split for ath(4)
> >
> >Please tell us whether you are testing these changes or not in the
> >commit message.
> 
> It's not even compile-tested:
> 
> sys/dev/cardbus/if_ath_cardbus.c:235: warning: passing argument 1 of 
> 'device_xname' from incompatible pointer type

One more point why all these changes should NOT be done at this stage.
I don't understand why such changes are still being made, while we are in
a freeze stage.

Bernd