[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/sys/dev/pci
Frank Wille wrote:
> On Mon, 16 Jun 2008 13:49:53 +1000
> Simon Burge <simonb%NetBSD.org@localhost> wrote:
> > > [ ... ]
> > > Also renamed the function to via_pegasos_mapregs_native(), which
> > > seems more appropriate.
> > Is the Pegasos the only thing that will ever use this functionality?
> I'm not sure. Might also be a VT8231 'feature'. But I haven't seen a
> 8231 on another board to compare.
> > This is an MI driver, so adding board-specific function names doesn't
> > seem like the right thing to do.
> Yes, you are right.
> Provided that the function is Pegasos-only indeed: would you just want
> to rename it, or even to remove the function completely (although I
> don't know how to deal with it outside of viaide.c)?
At a glance, it appears it's a mistake that another board could make -
the property that's being tested is "use-compat-native-irq". I think
I'd go with the original name or just via_mapregs_native().
Main Index |
Thread Index |