Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/pci

On Sun, May 25, 2008 at 05:22:23PM -0400, Jared D. McNeill wrote:
> Christoph Egger wrote:
>> Module Name: src
>> Committed By:        cegger
>> Date:                Sun May 25 20:51:22 UTC 2008
>> Modified Files:
>>      src/sys/dev/pci: nfsmb.c
>> Log Message:
>> add power management support
> No, your change doesn't add power management support at all, it only masks 
> the warning that the driver doesn't support it. Please revert this and fix 
> it properly.

This SMBus controller is a dumb device and essentially the same as an
ISA bridge. I didn't see anything that needs special handling when I was
reviewing this change a bit earlier.


Home | Main Index | Thread Index | Old Index