Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/common/lib/libprop

it seems completely wrong to me.
can you please try to find someone to review changes?


> Module Name:  src
> Committed By: xtraeme
> Date:         Tue May  6 22:57:26 UTC 2008
> Modified Files:
>       src/common/lib/libprop: prop_array.c prop_dictionary.c
>           prop_object_impl.h
> Log Message:
> prop_object_iterator_next() and prop_object_iterator_reset() were
> acquiring the rwlock recursively in some paths.
> Introduce _prop_rwlock_tryrdlock() and use it in these functions, so
> that the rwlock is *always* acquired once, while here add some
> _PROP_RWLOCK_OWNED asserts to verify.
> This definitely fixes the "locking against myself" panics.
> To generate a diff of this commit:
> cvs rdiff -r1.13 -r1.14 src/common/lib/libprop/prop_array.c
> cvs rdiff -r1.25 -r1.26 src/common/lib/libprop/prop_dictionary.c
> cvs rdiff -r1.21 -r1.22 src/common/lib/libprop/prop_object_impl.h
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

Home | Main Index | Thread Index | Old Index