Source-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/sys/dev/acpi/acpica



On Tue, Apr 22, 2008 at 09:50:44AM -0400, Jared D. McNeill wrote:

> Andrew Doran wrote:
> >On Tue, Apr 22, 2008 at 02:02:50AM +0000, Jared D. McNeill wrote:
> >
> >>Log Message:
> >>AcpiOsGetThreadId should return lwpid, not pid -- otherwise we always 
> >>return
> >>the same value! Fixes the AE_AML_MUTEX_NOT_ACQUIRED issue when evaluating
> >>_BST on ASUS Eee PC. Who knows what other mysterious bugs this has caused
> >>over the years...
> >
> >lwpids are only meaningful within a single process. What about defining 
> >ACPI_THREAD_ID to be ACPI_UINTPTR_T and just return curlwp as-is?
> 
> I had considered that, but AcpiOsGetThreadId is a kernel function and 
> the kernel and all associated kthreads are all the same process, right?

For kthreads that's true. Surely user processes call into the ACPI code at
some point too, though?

Thanks,
Andrew


Home | Main Index | Thread Index | Old Index