[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: src/lib/libc/gen
- Subject: Re: CVS commit: src/lib/libc/gen
- From: David Laight <david%l8s.co.uk@localhost>
- Date: Thu, 17 Apr 2008 21:24:54 +0100
On Thu, Apr 17, 2008 at 04:24:40PM +0000, Alan Barrett wrote:
> * Use toupper((int)(unsigned char)*s)) instead of just
> toupper((unsigned char)*s) in an example.
Why is the (int) cast needed.
The code is ugly enough without it.
I wonder if we should have defined some alternate functions/defines 
that exclude EOF from the domain, and can thus include the mask/cast
When I added all the (unsigned char) casts I don't remember finding
a single place where EOF could be passed to any of the ctype functions.
 picking a name is the hard part :-)
David Laight: david%l8s.co.uk@localhost
Main Index |
Thread Index |