Re: CVS commit: src/share/mk

[Tom Spindler <dogcow%babymeat.com@localhost>]

> Modified Files:
>       src/share/mk: bsd.sys.mk
> 
> Log Message:
> Don't make linker warnings fatal on linking static libs since
> there is no proper way to avoid "FOO is a patented algorithm" warnings.
> Ok'ed by christos@ on tech-toolchain.

Unfortunately, this bombs out for me during a build:
obj ===> lib/csu/alpha
nbmake: "/home/dogcow/work/nbsrc/share/mk/bsd.sys.mk" line 22: Malformed 
conditional (${MKPIC} != "no" && ${LDSTATIC} != "-static")
nbmake: "/home/dogcow/work/nbsrc/share/mk/bsd.sys.mk" line 22: Missing 
dependency operator
nbmake: Fatal errors encountered -- cannot continue

The following patch makes things work, however.
(I'm not convinced this is the proper place to put in the LDFLAGS
flag, though...)

--- bsd.sys.mk  14 Apr 2008 13:41:43 -0000      1.160
+++ bsd.sys.mk  14 Apr 2008 23:54:02 -0000
@@ -19,7 +19,7 @@ CFLAGS+=      -Wno-sign-compare -Wno-traditio
 # Set linker warnings to be fatal
 # XXX no proper way to avoid "FOO is a patented algorithm" warnings
 # XXX on linking static libs
-.if (${MKPIC} != "no" && ${LDSTATIC} != "-static")
+.if defined(MKPIC) && defined(LDSTATIC) && (${MKPIC} != "no") && (${LDSTATIC} 
!= "-static")
 LDFLAGS+=      -Wl,--fatal-warnings
 .endif
 .endif