Re: CVS commit: src/sys/net

[christos%zoulas.com@localhost (Christos Zoulas)]

On Mar 28, 11:27pm, yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) wrote:
-- Subject: Re: CVS commit: src/sys/net

| > On Mar 26,  1:38pm, yamt%mwd.biglobe.ne.jp@localhost (YAMAMOTO Takashi) 
wrote:
| > -- Subject: Re: CVS commit: src/sys/net
| > 
| > | what i care is const struct mbuf *, not (void *)memcpy.
| > 
| > Why, who's modifying it?
| > 
| > christos
| 
| currently no one is modifying it.
| however, IMO, it's an implementation detail.

When someone modifies it we can change it; the API for mbuf access should
make this clear and then compiler will complain. At that point we can add
the cast to memcpy, but that cast should be:
    (void (*)(void *, void *, size_t))
not
    (void *)

I dislike casts in general and since this can be avoided for now, I prefer
to keep the code the way it is right now.

christos