Re: CVS commit: src/sys/dev/pci

[David Young <dyoung%pobox.com@localhost>]

On Wed, Mar 12, 2008 at 01:40:48PM -0500, David Young wrote:
> On Wed, Mar 12, 2008 at 06:11:38PM +0000, Frank Wille wrote:
> > 
> > Module Name:        src
> > Committed By:       phx
> > Date:               Wed Mar 12 18:11:38 UTC 2008
> > 
> > Modified Files:
> >     src/sys/dev/pci: radeonfb.c unichromefb.c
> > 
> > Log Message:
> > Make console drivers support PCI_IOC_CFGREAD/WRITE ioctls. This is useful 
> > for
> > XFree86, which can alternatively find the graphics card through /dev/ttyE0.
> > Approved by macallan.
> 
> I am not sure that I understand this change.  Doesn't this give any user
> who has logged in on /dev/ttyE0 the ability to read/write any arbitrary
> register in configuration space?

Nevermind, macallan explained it to me.  These ioctls can only read/write
config space on the graphics card.

Unless XFree86 really needs it, I don't think that there should be *write*
access to configuration space through ttyE0.

Dave

-- 
David Young             OJC Technologies
dyoung%ojctech.com@localhost      Urbana, IL * (217) 278-3933 ext 24